Skip to content

Remove array api namespace - #2513

Open
mtar wants to merge 10 commits into
mainfrom
2420-remove_array_api_namespace
Open

Remove array api namespace#2513
mtar wants to merge 10 commits into
mainfrom
2420-remove_array_api_namespace

Conversation

@mtar

@mtar mtar commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • NEW unit tests: MPS tested (1 MPI process, 1 GPU)
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

This PR removes the Array API Namespace and moves the skips.txt and xfails.txt files for testing.

Issue/s resolved: #2420

Changes proposed:

  • Delete array_api
  • move skips.txt and xfails.txt to .github
  • update namespace in test

Type of change

Breaking Change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@mtar mtar added the array API Related to the array API standard label Aug 31, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Roadmap Aug 31, 2026
brownbaerchen
brownbaerchen previously approved these changes Aug 31, 2026
View reviewed changes

@brownbaerchen brownbaerchen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! What's the merge process for this? Can you trigger the array API tests on this branch and post the result?

@github-project-automation github-project-automation Bot moved this from Todo to Merge queue in Roadmap Aug 31, 2026
@codecov

codecov Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

brownbaerchen
brownbaerchen previously approved these changes Sep 1, 2026
View reviewed changes
@mtar

mtar commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

I removed the skips.txt and xfails.txt files as we are still improving support for Array API at the moment and don't have to edit them every time we're adding a function.

@mtar
mtar marked this pull request as ready for review September 1, 2026 13:45
@brownbaerchen

brownbaerchen commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

I removed the skips.txt and xfails.txt files as we are still improving support for Array API at the moment and don't have to edit them every time we're adding a function.

That means the array api tests will fail, though, right? I think having a list for what needs to be added is a good idea. I guess xfail makes the most sense. Then the tests would pass if we didn't change compatibility and fail if we extended or restricted compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brownbaerchen brownbaerchen brownbaerchen left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

array API Related to the array API standard

Projects

Roadmap
Status: Merge queue

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove array_api namespace

2 participants

@mtar @brownbaerchen